perf: avoid boxing provider futures for the default runtime - #290
Merged
baszalmstra merged 1 commit intoAug 27, 2026
Merged
Conversation
baszalmstra
marked this pull request as ready for review
August 27, 2026 07:45
baszalmstra
force-pushed
the
perf/private-immediate-queue
branch
from
August 27, 2026 07:45
b66a98a to
f23c60a
Compare
baszalmstra
enabled auto-merge (squash)
August 27, 2026 07:46
Merged
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the default
NowOrNeverRuntime, provider futures resolve on their first poll, but the encoder still boxes every future before polling it. That pays an allocation even though these futures never need the pending queue.This adds an internal queue mode. The default solver polls provider futures on the stack and stores ready results directly; solvers configured through
with_runtimekeep the existing boxedFuturesUnorderedpath, so custom runtimes that yield remain pending-capable without changing the public runtime contract.Performance
On 2,000 fixed-seed fast-workload cases in four rotated slices against upstream main:
The CSV workloads and solve/unsat outcomes matched. A separate tracking-allocator check reduced allocation count by 15.54% and allocated bytes by 9.45%; peak live memory was unchanged.
Testing
pixi run -e test-rust cargo fmt --checkpixi run -e test-rust cargo test --all-features