perf: bypass try_join_all for single requirements - #289
Merged
baszalmstra merged 1 commit intoAug 27, 2026
Conversation
baszalmstra
marked this pull request as ready for review
August 26, 2026 15:28
baszalmstra
enabled auto-merge (squash)
August 26, 2026 15:29
baszalmstra
force-pushed
the
perf/single-requirement-join
branch
from
August 27, 2026 07:31
879af5b to
31f4835
Compare
Keep union candidate requests concurrent while avoiding try_join_all's per-future bookkeeping for the common single-version-set case. Also lower solve-snapshot's default per-solve timeout to 10 seconds.
baszalmstra
force-pushed
the
perf/single-requirement-join
branch
from
August 27, 2026 07:38
31f4835 to
ae52f7b
Compare
Merged
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most requirements refer to a single version set, but candidate fetching still wraps each one in
try_join_all. That adds per-future bookkeeping to a very common path.This handles
Requirement::Singledirectly and keepstry_join_allfor unions, so union members remain concurrent when provider futures yield. It also changessolve-snapshot's default per-solve timeout from 60 seconds to 10 seconds.Performance
On 2,000 fixed-seed cases in four rotated slices against
902eafe:The paired workloads and solve/unsat outcomes matched. A separate tracking-allocator check reduced allocation count by 26.19% and allocated bytes by 37.58%; peak live memory was unchanged.
Testing
pixi run -e test-rust cargo fmt --checkpixi run -e test-rust cargo test --all-features