Feat/http callout#484
Check failed
All commits are incorrectly signed off, the check did not pass.
Summary
| Sha | Message | Pass or fail reason | |
|---|---|---|---|
| 🔴 | 434c279 | feat: add http_callout filter | Sign-off not found |
| 🔴 | abdbb06 | test: verify on_denied_headers removal (review fix... | Sign-off not found |
| 🔴 | 8499d40 | test: verify max_body_bytes 100 MiB cap (review fi... | Sign-off not found |
| 🔴 | bce5d30 | test: verify private/loopback IP warning (review f... | Sign-off not found |
| 🔴 | 8b4c160 | test: verify non-JSON response body skips extracti... | Sign-off not found |
| 🔴 | 1ba718c | test: verify deny_unknown_fields on nested configs... | Sign-off not found |
| 🔴 | 942278d | test: verify separator naming convention (review f... | Sign-off not found |
| 🔴 | 02e6bfd | fix: re-publish request_body-phase results in on_r... | Sign-off not found |
| 🔴 | c9c4015 | fix: warn and skip extraction values rejected by r... | Sign-off not found |
| 🔴 | b8db63c | fix: validate extraction result_key at config time | Sign-off not found |
| 🔴 | 1667830 | fix: remove dead failure_mode alias on on_failure | Sign-off not found |
| 🔴 | 205fd3d | fix: inject callout response headers with set sema... | Sign-off not found |
| 🔴 | d916a06 | docs: add generated http_callout filter reference ... | Sign-off not found |
| 🔴 | 242ceb8 | test: verify lakera-guard example bypasses non-POS... | Sign-off not found |
| 🔴 | 8931e37 | test: cover forward_headers absence and non-JSON s... | Sign-off not found |
| 🔴 | 8343038 | chore: minor cleanups from code review | Sign-off not found |
| 🔴 | a2def85 | style: apply nightly rustfmt to new tests | Sign-off not found |
Errors details
Sign-off not found
No sign-off was found in the commit message. This usually means that the author or committer of this commit failed to include a Signed-off-by line in the commit message. In some cases, this error can also be raised if the sign-off is not in the correct format.
To avoid having pull requests blocked in the future, always include a Signed-off-by: User1 <user1@email.test> line in every commit message. You can also do this automatically by using the -s flag (i.e., git commit -s).
How to fix missing or invalid sign-offs
Option 1: add remediation commit
Remediation commits are not allowed for this repository. For more details about how to enable them, please see the documentation.
Option 2: fix commits without sign-off
Rebase the branch
If you have a local git environment and meet the criteria below, one option is to rebase the branch and add your Signed-off-by lines in the new commits. Please note that if others have already begun work based upon the commits in this branch, this solution will rewrite history and may cause serious issues for collaborators (described in the git documentation under "The Perils of Rebasing").
Warning
You should only do this if:
- You are the only author of the commits in this branch
- You are absolutely certain nobody else is doing any work based upon this branch
- There are no empty commits in the branch
To add your Signed-off-by line to every commit in this branch:
- Ensure you have a local copy of your branch by checking out the pull request locally via command line.
- In your local branch, run:
git rebase HEAD~17 --signoff - Force push your changes to overwrite the branch:
git push --force-with-lease origin feat/http-callout