Skip to content

Edit page fetch - #78

Closed
rsidhi088 wants to merge 12 commits into
masterfrom
edit-page-fetch
Closed

Edit page fetch#78
rsidhi088 wants to merge 12 commits into
masterfrom
edit-page-fetch

Conversation

@rsidhi088

Copy link
Copy Markdown
Collaborator

Functionality to fetch details from the project panel page and edit them in the edit page.

@MelanyCristy MelanyCristy left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I requested a few things for make the cleaner

Comment thread frontend/src/App.js Outdated
import ProjPanel from "./components/Projects/ProjPanel";
import EditProject from "./components/Projects/EditProject";


Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blank space, please remove

Comment thread frontend/src/App.js Outdated


import Navbar from "./components/Navbar";

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blank space, please remove

Comment thread frontend/src/App.js Outdated
const loggedInRouter = (
<Router>

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blank space, please remove

Comment thread frontend/src/App.js
</Route>
</Switch>

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blank space, please remove

<div class="container-fluid">
<div className="form-group col-md-5">


Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blank space, please remove. It shouldn’t be spaces between divs only one at the end of each code element. Just for have in mind :D

/>

</div>

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blank space, please remove


</div>


Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blank space, please remove

import React from "react";
import { Link } from "react-router-dom";
import ProjectsApi from "./../../api/ProjectsApi";
import "./MyProjects.css";

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why removing this? Don't we need this css file? if don’t then i guess that file should be removed



</p>
<div class="container">

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change "class" to "className"

<div className="form-group col-md-4">
<label>Advanced Payment</label>


Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blank space, please remove :)

@pratima-shegokar pratima-shegokar left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After clicking edit button
Screenshot 2019-12-12 at 18 43 07

please solve the issue .

@rsidhi088

Copy link
Copy Markdown
Collaborator Author

Cancelling the pull request because working functionality merging with pull request #81 . The pull request have the same file edits and fetching the values and merged with abed branch .

@rsidhi088

Copy link
Copy Markdown
Collaborator Author

Closing

@rsidhi088 rsidhi088 closed this Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants