fix: tetherd silently ignored unknown flags and arguments - #13
Merged
Merged
Conversation
tetherd never inspected os.Args, so any flag or positional argument -- typo, --help, a stray word -- was dropped and the daemon started normally anyway. Found while testing v0.1.0: `tetherd -h` bound the default socket and hung instead of printing usage. parseArgs rejects anything on the command line via the stdlib flag package: -h/--help now print usage and exit 0, anything else exits 2. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
praneethravuri
added a commit
that referenced
this pull request
Aug 1, 2026
tetherd never inspected os.Args, so any flag or positional argument -- typo, --help, a stray word -- was dropped and the daemon started normally anyway. Found while testing v0.1.0: `tetherd -h` bound the default socket and hung instead of printing usage. parseArgs rejects anything on the command line via the stdlib flag package: -h/--help now print usage and exit 0, anything else exits 2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tetherdnever inspectedos.Args, so any flag or positional argument was silently dropped and the daemon started normally regardless. Found while testing v0.1.0's install:tetherd -hbound the default socket and hung instead of printing usage or erroring.parseArgs(stdlibflagpackage, no new dependency) now rejects anything on the command line:-h/--helpprint usage and exit 0, any unrecognized flag or stray positional argument prints an error and exits 2.Test plan
TestParseArgscovers: no args,-h,--help, unknown flag, stray positional arg-h/--helpexit 0 with usage,-xandfooexit 2 with a clear error, no more hanggo test -race -count=1 ./...,gofmt -s -l .,go vet ./...,golangci-lint runall clean🤖 Generated with Claude Code