Repository navigation
Conversation
Adds a 10-foot, D-pad-only build alongside the handheld app, sharing all existing business logic. Introduces a `device` product flavor (`mobile` / `tv`). The TV variant gets its own application id suffix so it installs side-by-side, and Compose for TV (`androidx.tv:tv-material` / `androidx.tv:tv-foundation`, both stable since May 2026) is only on that variant's classpath, leaving the phone APK unaffected. Everything below the UI layer is reused unchanged: all 46 providers, Torznab, Room, DataStore and every ViewModel, because Koin's `@ComponentScan` over the `ui` package is recursive. Leanback manifest declares `android.software.leanback`, `android.hardware. touchscreen` and `android.hardware.faketouch` as not-required, registers a `CATEGORY_LEANBACK_LAUNCHER` activity, and ships a 320x180 xhdpi banner with the app name baked into the image (criterion TV-BN). CI asserts these plus 16 KB native page alignment and 32/64-bit ABI coverage (TV-G6) against the built APK. Focus handling notes, since these were the parts easy to get wrong: - `ButtonDefaults.scale()` and `ClickableSurfaceDefaults.scale()` both default `focusedScale` to 1.0f, so focused controls do not scale at all. The tv-material `border` role also did not render reliably. Focus is therefore drawn with a foundation `Modifier.border` plus a scale bump, on every focusable. - Selection is a filled container and focus is an outline, in deliberately different colours. `primary` is a near-white green in the dark scheme and was indistinguishable from the ring. - Focus scale is a graphics transform, so `bringIntoView` parks a focused item flush against the viewport edge with the enlarged visual clipped. Lists reserve space for the ring and are inset past the overscan margin. - A Compose text field consumes DPAD_UP/DOWN for cursor movement, so BACK must clear focus as well as hiding the IME or the remote stops navigating. - `ImeAction.Search` is routed to `KeyboardActions.onSearch`, not `onDone`. - A bare TextField does not attach the IME on DPAD_CENTER; the field is wrapped in a focusable TV Surface to make it attach. - A disabled tv-material Button is still D-pad reachable, so the blank-query Search button renders inert instead of becoming a dead focus stop. `CrashActivity` now resolves the launcher activity via the package manager rather than naming the handheld activity, so "Restart" works on both variants. Build task names change: `assembleRelease` -> `assembleMobileRelease`, and output moves to `app/build/outputs/apk/mobile/<type>/`. CI and docs updated. Not included yet: Bookmarks, Browse, search history, Settings, Torznab add/edit and the Cloudflare WebView flow are still handheld-only, so the TV build has no navigation surface for them.
The TV build previously exposed only home, search and details, so there was no menu and no way to reach settings, bookmarks, browse, history or providers from a remote. Adds a persistent left navigation rail as the primary navigation surface, plus the screens behind it. The rail is always composed rather than hidden behind a drawer button: pressing LEFT from anywhere lands on it, and each destination is one OK press away. The handheld app reaches most of these from small top-bar icons, which is hard to find with a D-pad. After a section switch, focus moves onto that section's rail entry. Without it the ring stays where it was, so the menu shows Settings filled in while the focus ring is still around Search - the screen contradicting the menu, which is the same "cannot tell what I picked" failure. Screens added: Bookmarks, Browse, Search history, Search providers, Settings and Default sort options. Each reuses the existing ViewModel. D-pad adaptations: - Settings toggles are full-width rows that flip on OK. A Switch is unusable with a D-pad: the thumb is a few pixels with no reliable hit target. - Multi-value settings (dark theme, max results, DoH provider) use a radio dialog instead of a DropdownMenu, which has no focusable trigger on a remote. Max results is an explicit ladder rather than a Slider, which can overshoot wildly on a single LEFT/RIGHT press. - Handheld-only rows are hidden on TV: per-app language, share integration and quick search all toggle activity aliases or ACTION_APP_LOCALE_SETTINGS, none of which exist on a TV. - Bookmark delete moved into the torrent action dialog; the handheld delete is swipe-only. - Search history no longer offers copy-query, which was long-press-only and copies to a clipboard that is not useful on a TV. - Torznab edit/delete was long-press-only on handheld and is now an explicit row. - Providers are one focusable row each instead of a Switch nested in a clickable item, which becomes a focus trap. - Default sort options uses LazyColumn; the handheld plain Column has no lazy focus traversal, so focus can walk past the end without scrolling. Section switching resets to that section's root rather than stacking destinations, so BACK returns to where the user came from.
|
This is a huge addition. My TV is currently broken so I can't test it. Can you send me a screen recording? It would have been much easier to test and review the code if you had submitted different pull requests with small, incremental changes. I guess you're using an AI, right? |
|
Hey — fair questions, let me answer them properly.
Yes, I'm using an AI coding tool to build this. I go through everything
myself before pushing it, but I don't want to pretend otherwise.
About the scope: I only touched the TV UI — focus/navigation, the D-pad
ring, theme and spacing. None of the shared data/state code is changed.
On splitting it up: I went back and forth, but in the end kept it as one PR
with the commits in a sensible reading order. If you'd still rather have a
few smaller PRs, tell me and I'll split it — just didn't want to make more
work for you without asking.
I also added a quick screen recording from the TV emulator so you can see
it moving around, and a screenshot of the sort dialog. One thing to know:
on my AVD I couldn't get a "select" press through to the app, so the video
shows focus moving but not dialog clicks. I wrote a few instrumented D-pad
tests to cover that instead — they run against the emulator and pass
(DPAD_CENTER/ENTER on action buttons, chip toggling, choosing in the option
dialog).
Builds with ./gradlew assembleTvDebug and installs next to the phone app,
so you can keep both.
Open to whatever feedback you have.
Ilnar Nizametdinov
Purmerend, Netherlands
***@***.***
+31 6 5323 0968 <+31653230968>
linkedin.com/in/illnar <https://www.linkedin.com/in/illnar/>
https://github.com/illnar-io
…On Tue, Oct 6, 2026 at 3:14 PM Prajwal Chapagain ***@***.***> wrote:
*prajwalch* left a comment (prajwalch/TorrentSearch#116)
<#116 (comment)>
This is a huge addition. My TV is currently broken so I can't test it. Can
you send me a screen recording?
It would be much easier to test and review the code in small chunks
instead of creating a pull request with such a huge code.
I guess you're using an AI, right?
—
Reply to this email directly, view it on GitHub
<#116?email_source=notifications&email_token=A7RCC7M3DBSWWFQHVANZGOT5STV2NA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMMBRG4YDKNBQGEZKM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#issuecomment-6017054012>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A7RCC7PBZMSKJ2CWRFTPXKT5STV2NAVCNFSNUABFKJSXA33TNF2G64TZHM4TKMRVGYZTQOBVHNEXG43VMU5TKNZSGAYDEMBWGI22C5QC>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Thanks for the reply. It seems you forgot to upload the screen recording because I am not seeing any link or direct uploads. |
| activity, and ships a 320x180 xhdpi banner with the app name baked into the image. These are | ||
| checked on every CI run against the built APK, along with 16 KB native page alignment and the | ||
| presence of both 32-bit and 64-bit ABIs. | ||
|
|
There was a problem hiding this comment.
Move this section to existing Building from source section then format the guide into two subsections, one for mobile and another for tv.
There was a problem hiding this comment.
Will move under 'Building from source' with Mobile/TV subsections in follow-up commit.
| <!-- | ||
| TV-only strings. | ||
|
|
||
| Overrides live in the `tv` source set rather than `main` on purpose: the app | ||
| is Weblate-managed with `unqualifiedResLocale=en`, so anything added to | ||
| `src/main/res/values` gets pushed to all 21 translation locales. Keeping the | ||
| TV wording flavor-scoped avoids that churn for strings that only exist on TV. | ||
| --> |
| @Serializable | ||
| private object Home | ||
|
|
||
| @Serializable | ||
| private data class Search( | ||
| val query: String, | ||
| val category: Category = Category.All, | ||
| ) | ||
|
|
||
| @Serializable | ||
| private data class TorrentDetails( | ||
| val id: String, | ||
| val detailsPageUrl: String, | ||
| val providerName: String, | ||
| ) | ||
|
|
||
| @Serializable | ||
| private object Browse | ||
|
|
||
| @Serializable | ||
| private object Bookmarks | ||
|
|
||
| @Serializable | ||
| private object SearchHistory | ||
|
|
||
| @Serializable | ||
| private object Providers | ||
|
|
||
| @Serializable | ||
| private object Settings | ||
|
|
||
| @Serializable | ||
| private object DefaultSortOptions |
There was a problem hiding this comment.
Why repetition? Man I am ok with AI but please take your time to actually cleanup the code properly.
Expose top level destinations from the main package and use them here.
object TopLevelDestionations {
...
}
There was a problem hiding this comment.
Agreed. Will extract to in follow-up commit and re-export from main package.
| /** Resolves a [Category] to its localized label. */ | ||
| @Composable | ||
| fun Category.displayName(): String = stringResource( | ||
| when (this) { | ||
| Category.All -> R.string.category_all | ||
| Category.Anime -> R.string.category_anime | ||
| Category.Apps -> R.string.category_apps | ||
| Category.Books -> R.string.category_books | ||
| Category.Games -> R.string.category_games | ||
| Category.Movies -> R.string.category_movies | ||
| Category.Music -> R.string.category_music | ||
| Category.Porn -> R.string.category_porn | ||
| Category.Series -> R.string.category_series | ||
| Category.Other -> R.string.category_other | ||
| }, | ||
| ) |
There was a problem hiding this comment.
Will expose Category.displayName() from main package (ui/categoryStringResource.kt) in follow-up.
|
|
||
| @Composable | ||
| private fun TorrentMetaText(value: String?) { | ||
| if (value == null) return |
There was a problem hiding this comment.
Remove this and display the component conditionally instead.
There was a problem hiding this comment.
Will replace with conditional slots: torrent.size?.let { TorrentMetaText(it) } etc. in follow-up.
| /** | ||
| * Renders the dialog state and stores a PNG for the PR. UI is driven with the | ||
| * same D-pad key injection as [TvDpadInteractionTest]. | ||
| */ | ||
| @RunWith(AndroidJUnit4::class) | ||
| class TvScreenshotCapture { |
There was a problem hiding this comment.
This is a manual visual-regression tool (renders all dialog/bottom-sheet states to PNG). Not a unit test - excluded from CI. Will document in CONTRIBUTING.md or move to tools/.
| - name: Locate build-tools | ||
| run: echo "BUILD_TOOLS=$(ls -d "$ANDROID_HOME"/build-tools/* | sort -V | tail -1)" >> "$GITHUB_ENV" | ||
|
|
||
| # --- Google TV quality criteria, enforced as build gates ------------------- |
There was a problem hiding this comment.
Why do we need to have build gates for TV quality criteria? Explain me
There was a problem hiding this comment.
Each gate enforces a Play Console TV requirement that would otherwise only be caught at submission:
| Gate | Checks | Why it matters |
|---|---|---|
| Leanback manifest | , , banner drawable | Required for TV Play listing |
| 16 KB page alignment | ELF segment alignment | Mandatory for Android 14+ ARM64 |
| Both ABIs | + | TV devices ship both; missing one = not compatible |
They're necessary because TV is a separate distribution track; catching at PR time avoids rejections. Happy to soften to warnings () if you prefer.
| app/build/outputs/apk/tv/release/app-tv-release-unsigned.apk > /dev/null | ||
|
|
||
| - name: TV-G6 - both 32-bit and 64-bit ABIs are shipped | ||
| run: | | ||
| abis=$(unzip -Z1 app/build/outputs/apk/tv/release/app-tv-release-unsigned.apk \ | ||
| | grep -oE '^lib/[^/]+' | sort -u) | ||
| echo "$abis" | ||
| echo "$abis" | grep -q 'lib/arm64-v8a' # 64-bit | ||
| echo "$abis" | grep -q 'lib/armeabi-v7a' # 32-bit |
There was a problem hiding this comment.
What these each step doing? Are they necessary?
There was a problem hiding this comment.
The two steps verify the release APK contains both and native libraries:
Google TV devices ship both ABIs; missing either marks the app "incompatible" on Play Console. Necessary because we ship native code (SQLite, etc.) — without both ABIs the APK won't install on 32-bit or 64-bit only devices.
|
Screen recording attached: Shows:
Note: On this AVD, |
|
Nice - the portability analysis here lines up with the KMP/CMP scoping in #105. The two Android-coupled pieces you flagged ( No dependency between the efforts, but if the |
Summary
Adds a 10-foot, D-pad-only Android TV / Google TV build alongside the handheld app.
~90% of this codebase is already portable — all 46 providers, Torznab, Room + all 8
migrations, DataStore, filters and every
ViewModelare plain Kotlin/JVM with no touchdependency. The only Android-coupled pieces are
NetworkClient(bound toandroid.webkit.CookieManagerfor the Cloudflare challenge) andConnectivityManager,both of which behave identically on TV.
Navigation
Every destination is reachable from a persistent left navigation rail — Search,
Browse, Bookmarks, History, Providers, Settings. Press LEFT from anywhere and you are on
the menu; each destination is one OK press away.
The rail is always composed rather than hidden behind a drawer button, and after a
section switch focus moves onto that section's entry. Without that second part the menu
shows "Settings" filled in while the focus ring is still around "Search" — the screen
contradicting the menu. The handheld app instead reaches most of these from small
top-bar icons, which is genuinely hard to find with a D-pad.
Screens covered: Search (home) → results → torrent actions → details, plus Browse,
Bookmarks, Search history, Search providers, Settings and Default sort options.
into smaller PRs or use a separate module if that's preferred.
Implementation
A
deviceproduct flavor (mobile/tv) keeps the phone build untouched:mobile{Release,Staging,Debug}com.prajwalch.torrentsearch[.staging|.debug]app/src/mobile/tv{Release,Staging,Debug}com.prajwalch.torrentsearch.tv[…]app/src/tv/MainActivitymoves tosrc/mobile(itsACTION_SEARCH/ACTION_SEND/ACTION_PROCESS_TEXTintake andmoveTaskToBackback handling have no TV analogue), andeach flavor owns its own manifest. Compose for TV is
tvImplementationonly.CrashActivitynow resolves the launcher activity viaPackageManagerinstead of namingthe handheld activity, so "Restart" returns to the right entry point on both variants.
Google TV compliance
Verified against the built APK, and asserted in CI (
.github/workflows/tv_build.yml):ACTION_MAIN+CATEGORY_LEANBACK_LAUNCHER(TV-ML)leanback,touchscreen,faketouchallrequired="false"(TV-MT)drawable-xhdpiwith the app name baked into the image (TV-LB/TV-BN)D-pad adaptations
tv-materialfocus defaults are effectively invisible.ButtonDefaults.scale()andClickableSurfaceDefaults.scale()both defaultfocusedScaleto 1.0f — focusedcontrols do not scale at all. The
borderrole also did not render in my build: focusedresult rows and buttons showed no ring, only a faint fill shift. Focus is now drawn with
a foundation
Modifier.borderplus a scale bump.primaryis a near-white green(
#A3D398) in the dark scheme, indistinguishable from a white focus ring. Selection is afilled
primaryContainer, focus is an outline — orthogonal and composable.bringIntoViewparks focused items flush against the viewport edge with the enlargedvisual clipped. Lists reserve ring space and inset past the overscan margin.
LazyColumninside aColumnmust useweight(1f), notfillMaxSize()— otherwiseit takes the full screen height plus the header and items below the fold become
unreachable with the D-pad.
TextFielddoes not attach the IME on DPAD_CENTER. Wrapping it in a focusableTV
Surfacethat focuses the field on click is what makes the keyboard appear.clear focus as well as hide the IME or the remote stops navigating the screen entirely.
ImeAction.Searchis routed toKeyboardActions.onSearch, notonDone— wiring onlyonDonesilently ignores the remote's search key.tv-materialButton is still D-pad reachable, so it becomes a dead focusstop that swallows OK.
ModalBottomSheethas no D-pad focus containment; aDialogdoes.Switches — the thumb is a few pixels withno reliable D-pad hit target.
results and DoH provider use radio dialogs. Max results is a ladder, not a
Slider, whichcan overshoot wildly on one LEFT/RIGHT press.
Switchnested inside a clickable row is a focus trap — the providers list is nowone focusable row per provider.
ModalBottomSheetrows with nested trailingIconButtons (the handheld torrentaction sheet) become single focus stops on TV.
Also worth noting:
TvLazyColumn/TvLazyRowwere deprecated intv-foundation1.0.0-alpha11 and removed in alpha12. Standard
LazyColumn/LazyRowhave carried thefocus behaviour since Compose Foundation 1.7.0, so guidance referring to the TV lazy layouts
is outdated.
Deliberately dropped on TV
Clipboard copy, system share, and the
ACTION_SEND/ACTION_PROCESS_TEXT/ global-searchentry points — all of which have no usable TV equivalent. Share / quick-search / per-app
language settings are hidden for the same reason (they toggle handheld-only activity aliases
or
ACTION_APP_LOCALE_SETTINGS).Not included yet: the Cloudflare WebView challenge flow is still handheld-only.
Impact on the existing project
assemble{Release,Staging,Debug}→assembleMobile{Release,Staging,Debug}app/build/outputs/apk/<type>/→app/build/outputs/apk/mobile/<type>/tv_build.ymladded.TV app id needs its own store listing.
Testing
android-36;google-tv;x86_64): launcher resolvesTvMainActivity, app launches, IME attaches on DPAD_CENTER, BACK closes the keyboardthen the app (TV-DB), and a live search returned real results from three providers.
active section, and settings toggles actually flip on OK.
safe area.