Repository navigation
Conversation
6 of 8 tasks
Contributor
Author
|
May be an idea to add some unit tests for each provider? |
added 4 commits
October 10, 2026 14:14
Prevents module build outputs (e.g. androidApp/build) from showing up as untracked files.
Ksoup is a KMP-compatible Jsoup port, preparing HTML parsing for a future multiplatform split.
Update imports and parse calls across HTML providers, and replace nodeValue() with TextNode.text() where Ksoup's Node API differs.
markst
force-pushed
the
migrate/jsoup-to-ksoup
branch
from
October 13, 2026 03:22
232b0bf to
0761306
Compare
markst
marked this pull request as ready for review
October 13, 2026 03:23
Contributor
Author
|
A note on review scope: the migration itself is small (45 files, +197/−196), but the test commits add 136 files and ~22k lines, mostly HTML fixtures (~1.3 MB). That makes the PR much heavier to review than the change it covers. Happy to go either way:
Either way, the full suite has already shown that parsing behaves the same: all 199 tests pass unchanged on |
Owner
|
Leave this PR only for Jsoup -> Ksoup migration. |
markst
force-pushed
the
migrate/jsoup-to-ksoup
branch
from
October 13, 2026 04:12
0761306 to
917debe
Compare
This was referenced Oct 13, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in #108 (comment), a few steps are needed before the app can go multiplatform. This PR does the first one: it replaces Jsoup with fleeksoft/ksoup, a Kotlin Multiplatform port of Jsoup.
Summary
0.2.6(latest).org.jsouptocom.fleeksoft.ksoup. The API is almost identical. The only differences:nodeValue()becomesTextNode.text()(AnimeTosho, BlueRoms, Eztv).parse(xml, baseUri, parser)changes toparse(xml, parser)(Torznab results).**/build/directories so module build outputs aren't shown as untracked.Rebased onto current
main, including the Torznab move to Jsoup XML parsing (100b3f2), which is now migrated to Ksoup as well. Noorg.jsoupreferences remain.Unit tests for the migrated parsers are in a separate stacked PR, #118.
Test plan
./gradlew :app:compileDebugKotlin./gradlew :app:assembleDebug :app:lintDebug: builds, no lint issues./gradlew :app:assembleStaging(R8-minified): buildsmain(Jsoup) and this branch (Ksoup). That coversabs:hrefresolution and the formernodeValue()paths in Eztv, BlueRoms and AnimeTosho.androidApp/build(and other nestedbuild/) stay ignored by git