refactor(arch): 헥사고날 아키텍처 폴더 위치 정렬#50
Merged
Merged
Conversation
ppzxc
commented
Mar 24, 2026
ppzxc
left a comment
Owner
Author
There was a problem hiding this comment.
구조적 변경만 포함된 깔끔한 리팩토링입니다. 동작 변경 없음 확인.
✅ apidocs HTTP 핸들러가 adapter/input/http 하위로 올바르게 배치됨
✅ InMemoryRuleConfigReader가 출력 포트 구현체로 adapter/output/config에 정확히 위치
✅ hot-reload Update() 호출부 정상 작동 확인
✅ 해결된 RED 주석 제거
사소한 지적:
cmd/server/main.go — outputconfig import가 알파벳 순서상 filequeue 앞에 위치해야 함 (config < filequeue < mariadb < sqlite < webhook)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
internal/apidocs/→internal/adapter/input/http/apidocs/로 이동internal/config/InMemoryRuleConfigReader→internal/adapter/output/config/(패키지명outputconfig)로 이동Motivation
헥사고날 아키텍처(Ports & Adapters) 원칙에 따라 각 컴포넌트를 올바른 레이어에 배치한다.
apidocs는 HTTP 입력 어댑터이므로adapter/input/http/하위로 이동InMemoryRuleConfigReader는 출력 포트(RuleConfigReader) 구현체이므로adapter/output/하위로 이동Changes
internal/apidocs/→internal/adapter/input/http/apidocs/(패키지명 유지)internal/config/rule_config_reader.go→internal/adapter/output/config/(패키지명outputconfig)cmd/server/main.go,test/e2e/e2e_test.goimport 경로 업데이트Test plan
go build ./...)go test -race ./... -timeout 60s)