Refactor cache logic#567
Draft
danschultzer wants to merge 1 commit into
Draft
Conversation
44c6f2f to
4a3e450
Compare
5db758b to
2f0eeae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial work towards a refactor of cache logic
The first step was to move invalidation of existing active sessions to the
Pow.Plug.Sessionmodule. It doesn't seem right thatPow.Store.CredentialsCacheshould know about:fingerprint.Next steps:
Pow.Plug.delete_user/2#404)Before using erlang match spec, the keys where just binary name spaced values. It was necessary to create three records to pull in all sessions for a user or all users for the sessions. With the match spec I believe that it might be possible to change
Pow.Store.CredentialsCacheto only use one query to fetch session, sessions for a user, and users for all sessions.