Repository navigation
fix(parser): recover XML list items with mismatched closing tags - #495
Merged
Merged
Conversation
A model can close one list item with another tag, causing the parser to\nfuse it with the next item or drop it entirely. Keep adjacent items\nseparate without stripping markup from correctly closed items. Refs: #472 Generated-By: gpt-6.2-sol
Only real child delimiters should split items. Keep nested content\nand recover a mismatched close even before an inter-item comment. Generated-By: gpt-6.2-sol
Owner
Author
|
Code review: standard scan, clean. Axes: Standards+Spec, Correctness/Logic Reviewed-Head: 9ac417b |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Closes #472
Recover separate list items when a model closes one with the wrong tag, so adjacent items do not fuse and a trailing mismatched close does not become stored text.
Read first
src/prompts/xml.ts:53— list parsing shared by Summary, Observation compression, and consolidation.test/xml.test.ts— malformed items, nested markup, and opaque XML sections.Decisions
Out of scope
Verified
npm run build,npm run skills:check,npm run typecheck,npm test,npm run eval:gate, andnpm run eval:gate:rulespassed (3,222 tests, one skipped) in the current-base checkout; generated hooks were unchanged.Not verified
Merge danger
Door: A revert restores the previous parser for future replies; it does not rewrite any records produced in the meantime.
Blast radius: List fields in newly parsed Summaries, Observation compression, and consolidation.