Skip to content

fix: exclude unresolvable Memories from project Recall - #494

Merged
possiblyneal merged 1 commit into
mainfrom
fix/441-project-recall
Nov 21, 2026
Merged

possiblyneal merged 1 commit into
mainfrom
fix/441-project-recall

Conversation

@possiblyneal

Copy link
Copy Markdown
Owner

Intent

Closes #441

Keep non-Global Memories with no resolvable project out of project-scoped Recall.

Read first

  • src/functions/search.ts
  • test/project-matcher-unscoped-memory.test.ts

Decisions

  • Prefer the Memory’s own project over its Session or Summary; keep the fallback for older Memories that lack a project.

Out of scope

  • Global and unscoped Recall and the Observation fallback retain their existing behavior.

Verified

  • npm run build, npm run skills:check, npm run typecheck, npm test, npm run eval:gate, and npm run eval:gate:rules passed in an isolated checkout; generated hooks were unchanged.

Not verified

  • No live store or provider was used.

Merge danger

Door: Two-way; no storage rewrite.

Blast radius: Project-scoped Memory Recall.

@possiblyneal
possiblyneal merged commit 0368c8f into main Nov 21, 2026
3 checks passed
@possiblyneal
possiblyneal deleted the fix/441-project-recall branch November 21, 2026 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unscoped Memories pass every project filter in Recall

1 participant