Skip to content

fix: preserve structured capture during secret redaction - #493

Merged
possiblyneal merged 1 commit into
mainfrom
fix/435-capture-redaction
Nov 21, 2026
Merged

possiblyneal merged 1 commit into
mainfrom
fix/435-capture-redaction

Conversation

@possiblyneal

Copy link
Copy Markdown
Owner

Intent

Closes #435

Redact secrets before storing Observation payloads without converting structured values into strings.

Read first

  • src/functions/privacy.ts and src/functions/observe.ts
  • test/capture-redaction.test.ts covers the capture path.

Decisions

  • Scrub values while preserving payload shape so downstream consumers can still inspect structured capture.

Out of scope

  • Previously stored Observations are not rewritten.

Verified

  • npm run build, npm run skills:check, npm run typecheck, npm test, npm run eval:gate, and npm run eval:gate:rules passed in an isolated checkout; generated hooks were unchanged.

Not verified

  • No live store or provider was used.

Merge danger

Door: One-way for new captures: redacted text is not recoverable on revert.

Blast radius: Observation capture, storage, and downstream consumers of raw payloads.

@possiblyneal
possiblyneal merged commit 1d6f27d into main Nov 21, 2026
3 checks passed
@possiblyneal
possiblyneal deleted the fix/435-capture-redaction branch November 21, 2026 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Capture redaction corrupts structured raw data and misses JSON-shaped secrets

1 participant