Repository navigation
fix: filter Lesson Recall before cutting candidates - #492
Closed
possiblyneal wants to merge 1 commit into
Closed
possiblyneal wants to merge 1 commit into
possiblyneal wants to merge 1 commit into
Conversation
Generated-By: claude-sonnet-5-5
Owner
Author
|
Shelving this implementation without merging. Ranking all matching Lessons can take quadratic work on the daemon event loop, and the benchmark does not establish a reranked Injection gain. Keep #438 open for bounded candidate selection and representative quality and latency measurements. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Closes #438
Higher-scoring hits from other projects no longer crowd eligible Lessons out of the candidate window. Global Lessons remain eligible.
Read first
src/functions/lessons.ts:58— prompt-submit Lesson selection filters before cutting the list.src/functions/lessons.ts:237— Lesson Recall applies the same ordering of filtering and cutting.docs/benchmarks/2026-11-20-scoped-lesson-candidates.md— measured results and limitations.Decisions
Out of scope
Verified
npm run build && npm run typecheck && npm test→ 3,195 passed, one skipped.npm run eval:gate && npm run eval:gate:rules→ both passed.Not verified
Merge danger
Door: A revert restores the old candidate cut; the change does not modify stored records.
Blast radius: Lesson Recall and the Lesson candidate offered to prompt-submit Injection.