Repository navigation
perf: count observations before loading session-cap candidates - #491
Merged
Merged
Conversation
Generated-By: claude-sonnet-5-5
Owner
Author
|
Code review: standard scan, clean. Axes: Standards+Spec, Correctness/Logic Reviewed-Head: 60d7b66 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Closes #479
Avoid loading every Observation on each capture when the Session is still within its cap. Keep existing victim selection when it exceeds the cap.
Read first
src/functions/observe.ts:91— count before loading eviction candidates.docs/benchmarks/2026-11-21-session-cap-count.md— measurement and limits.Decisions
Out of scope
Verified
npm run build→ passed; no tracked generated changes.npm run typecheck && npm test→ 3,190 passed, one skipped.Not verified
Merge danger
Door: A revert restores the previous row loading behavior.
Blast radius: Observation capture and Session-cap eviction.