Repository navigation
fix: scope auto-forget contradictions and release images after delete - #489
Merged
Merged
Conversation
…#437) Generated-By: gpt-6.2-sol
Node clamps an overflowing timer to one millisecond. Fall back to the hourly default instead. Failed image releases must not hide committed Memory deletes from audit and graph cleanup; do not blindly retry a reference decrement that may have partially completed. Generated-By: claude-opus-5-5
Owner
Author
|
Code review: standard scan, clean. Axes: Standards+Spec, Correctness/Logic Reviewed-Head: fa18021 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Closes #437
Auto-forget no longer treats Memories in different scopes as contradictions. Auto-forget and retention release image references only after deleting the indexed Memory. Invalid intervals fall back to the hourly default with a warning.
Read first
src/functions/auto-forget.ts:15— project, Global marker and agent define the comparison scope.src/functions/retention.ts:349— delete before releasing an image reference.src/config.ts:541— validate the scheduled interval against Node’s timer limit.Decisions
Out of scope
Verified
npm run typecheck && npm test→ 3,184 passed, one skipped.Not verified
Merge danger
Door: A revert restores the old behavior but does not recover records removed by maintenance.
Blast radius: Scheduled and manual auto-forget, retention eviction, and image reference accounting.