Skip to content

fix: scope auto-forget contradictions and release images after delete - #489

Merged
possiblyneal merged 2 commits into
mainfrom
fix/437-auto-forget-scope
Nov 21, 2026
Merged

possiblyneal merged 2 commits into
mainfrom
fix/437-auto-forget-scope

Conversation

@possiblyneal

@possiblyneal possiblyneal commented Nov 21, 2026 •

Copy link
Copy Markdown
Owner

Intent

Closes #437

Auto-forget no longer treats Memories in different scopes as contradictions. Auto-forget and retention release image references only after deleting the indexed Memory. Invalid intervals fall back to the hourly default with a warning.

Read first

  • src/functions/auto-forget.ts:15 — project, Global marker and agent define the comparison scope.
  • src/functions/retention.ts:349 — delete before releasing an image reference.
  • src/config.ts:541 — validate the scheduled interval against Node’s timer limit.

Decisions

  • Legacy unscoped Memories cannot supersede scoped Memories, as confirmed by the Operator.
  • Log failed image releases without interrupting deletion bookkeeping. A blind retry risks decrementing a shared reference twice.

Out of scope

Verified

  • npm run typecheck && npm test → 3,184 passed, one skipped.

Not verified

  • Live daemon maintenance; verification used the local test suite only.

Merge danger

Door: A revert restores the old behavior but does not recover records removed by maintenance.

Blast radius: Scheduled and manual auto-forget, retention eviction, and image reference accounting.

Node clamps an overflowing timer to one millisecond. Fall back to the
hourly default instead. Failed image releases must not hide committed
Memory deletes from audit and graph cleanup; do not blindly retry a
reference decrement that may have partially completed.

Generated-By: claude-opus-5-5
@possiblyneal

Copy link
Copy Markdown
Owner Author

Code review: standard scan, clean.

Axes: Standards+Spec, Correctness/Logic

Reviewed-Head: fa18021

@possiblyneal
possiblyneal merged commit 722b5e7 into main Nov 21, 2026
3 checks passed
@possiblyneal
possiblyneal deleted the fix/437-auto-forget-scope branch November 21, 2026 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Auto-forget's contradiction pass supersedes Memories across projects

1 participant