Skip to content

Unscoped Memories pass every project filter in Recall #441

Closed

Description

@possiblyneal

Problem

createProjectMatcher lets a Memory with no project, no Session and no Summary pass every project filter (summaryProject === null returns true). Legacy or unscoped Memories therefore surface in every repo's project-scoped recall, against the Goal's "one repo's work never surfaces in another's". The matcher also reads the Session before honouring a Memory's own explicit project, and a failed Session read fails recall.

Evidence

  • src/functions/search.ts:574-600

Upstream diagnosis: rohitg00#1647 (merged), rohitg00#1723 (merged).

Acceptance criteria

  • A non-Global Memory with no resolvable project is excluded from project-scoped recall (Observations keep today's pass-through, which the code comment justifies)
  • A Memory's explicit project is checked before any Session read
  • Count unscoped non-Global Memories on the live store (read-only) and report the number in the PR
  • npm run eval:gate passes

Activity

  1. added
    bugSomething isn't working
    ready-for-agentFully specified, ready for an AFK agent
    needs-triageMaintainer needs to evaluate this issue
    and removed
    ready-for-agentFully specified, ready for an AFK agent
    on Nov 18, 2026
  2. possiblyneal commented on Nov 18, 2026

    @possiblyneal
    OwnerAuthor

    Not verified on this tree yet. Held at needs-triage until Should unscoped Memories pass a project filter? gives a tested verdict: a failing reproduction and a fix that works here, or a reject.

  3. possiblyneal commented on Nov 18, 2026

    @possiblyneal
    OwnerAuthor

    Verdict: apply (verified 2026-11-18)

    A project filter now excludes unscoped, non-Global Memories, with no migration (the Operator's call). Repro, fix and measurements: Should unscoped Memories pass a project filter?. Branch verify/441-unscoped-memory, not committed.

  4. added
    ready-for-agentFully specified, ready for an AFK agent
    and removed
    needs-triageMaintainer needs to evaluate this issue
    on Nov 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingready-for-agentFully specified, ready for an AFK agent

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions