Skip to content

Scrub secrets in every function that stores Agent-supplied text #37

Closed

Description

@possiblyneal

Parent

Part of #31.

Branch: fix/security

What to build

A token pasted into any MCP write tool never lands in the store. The existing scrub moves below the MCP layer: every registered function that persists Agent-supplied free text (remember, lesson-save, semantic and procedural store, action-create, checkpoint-create, signal-send, sentinel-create, facet-tag, and any other content-bearing writer found while implementing) applies it before writing. observe keeps its current call; MCP handlers are unchanged.

Acceptance criteria

  • For each write function, driving the registrar with content containing a known secret pattern stores the scrubbed value
  • The PR body lists every write function that now scrubs, so a reviewer can see the set is complete
  • npm test green

Blocked by

Activity

  1. added a commit that references this issue on Sep 22, 2026
    62e2f63
  2. possiblyneal commented on Sep 22, 2026

    @possiblyneal
    OwnerAuthor

    Closed by 62e2f63 on fix/security. The commit message lists every writer and field that now scrubs; there is no semantic or procedural store function in this tree, they derive from already-scrubbed Observations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    ready-for-agentFully specified, ready for an AFK agent

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions