Conversation
|
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
tdstein
reviewed
Apr 29, 2026
Collaborator
tdstein
left a comment
tdstein
left a comment
There was a problem hiding this comment.
Are you considering [project.optional-dependencies] support as well?
Collaborator
Author
It's something we should design for, but I considered it out of scope as we don't seem to have any support for optional dependencies in general at the moment (independently from pyproject) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Allow to pass
--requirements-file pyproject.tomltorsconnect deployso that it is not necessary to create a redundantrequirements.txtType of Change
Approach
Mimic #749
Automated Tests
added some dedicated tests
Directions for Reviewers
--requirements-file pyproject.tomlChecklist
rsconnect-python-tests-at-nightworkflow in Connect against this feature branch.