Skip to content

fix for change in repo/branches format#524

Merged
karawoo merged 1 commit intomainfrom
connectapi-integration
Apr 23, 2026
Merged

fix for change in repo/branches format#524
karawoo merged 1 commit intomainfrom
connectapi-integration

Conversation

@karawoo
Copy link
Copy Markdown
Collaborator

@karawoo karawoo commented Apr 22, 2026

Intent

Fix integration tests, which failed on the nightly connect build this week:
https://github.com/posit-dev/connectapi/actions/runs/24657089648/job/72093203473

Approach

Add a helper than can parse either the old format or the new.

Checklist

  • Does this change update NEWS.md (referencing the connected issue if necessary)?
  • Does this change need documentation? Have you run devtools::document()?
  • Does this change resolve integration test failures for a preview build of Connect? If so (and if you are on the Connect team), please be sure to update the Connect changelog to reflect that users will need to upgrade their version of connectapi.

@karawoo
Copy link
Copy Markdown
Collaborator Author

karawoo commented Apr 22, 2026

Does this change resolve integration test failures for a preview build of Connect? If so (and if you are on the Connect team), please be sure to update the Connect changelog to reflect that users will need to upgrade their version of connectapi.

Not sure whether this makes sense to surface in the changelog given that it deals with an internal, unversioned API. That said, if a customer is using connectapi for things dealing with git and they run into this issue, they should have some way of knowing that they need to upgrade. It's not their fault that connectapi is using internal APIs. @jonkeane let me know what you think.

@karawoo karawoo requested a review from a team April 22, 2026 23:25
Copy link
Copy Markdown
Collaborator

@jonkeane jonkeane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good, thanks for jumping on these

Not sure whether this makes sense to surface in the changelog given that it deals with an internal, unversioned API.

I agree with your assessment that it's not worth calling out in the Connect changelog.

@karawoo
Copy link
Copy Markdown
Collaborator Author

karawoo commented Apr 23, 2026

Sounds good, I also checked the connect extensions and didn't find any that rely on this functionality, so I think the extensions should keep running fine regardless (breaking these was what prompted us to add that PR checklist item).

@karawoo karawoo merged commit 631b6d6 into main Apr 23, 2026
23 checks passed
@karawoo karawoo deleted the connectapi-integration branch April 23, 2026 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants