fix: forward on insert.text breaks undo batching#2243
Draft
christianhg wants to merge 1 commit intomainfrom
Draft
fix: forward on insert.text breaks undo batching#2243christianhg wants to merge 1 commit intomainfrom
christianhg wants to merge 1 commit intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a behavior uses
forward(event)oninsert.textwith a second action set, each typed character becomes its own undo step instead of merging with adjacent characters.This breaks the expected undo behavior for any behavior that observes text insertion without modifying it (e.g., a behavior that forwards the text and then checks the block content to update styles).
Root cause
performEventsets a uniqueundoStepIdfor everyinsert.textevent because it's synthetic (not innativeBehaviorEventTypes). Without custom behaviors, the default handler clearsundoStepIdbefore running the operation, so consecutive characters merge. But when a behaviorforwards the event,defaultBehaviorOverwritten = trueand the clearing never happens. Each character gets a uniqueundoStepId, preventing history merge.Status
Failing tests added. Fix pending.