fix: replace is-hotkey with @portabletext/keyboard-shortcuts#2239
Open
christianhg wants to merge 1 commit intomainfrom
Open
fix: replace is-hotkey with @portabletext/keyboard-shortcuts#2239christianhg wants to merge 1 commit intomainfrom
christianhg wants to merge 1 commit intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 72cdea4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
142ae2a to
e418d83
Compare
e418d83 to
46735ea
Compare
…ey doesn't ship ESM.
46735ea to
72cdea4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Replaces the
is-hotkeydependency with@portabletext/keyboard-shortcuts(already in the monorepo).Why
is-hotkeydoesn't ship ESM.How
Rewrote
packages/editor/src/slate-dom/utils/hotkeys.tsto usecreateKeyboardShortcut(). Each hotkey is defined with explicitKeyboardEventDefinitionobjects instead ofis-hotkeystring syntax.All modifier constraints are explicit.
is-hotkeydefaults unmentioned modifiers tofalse(must be off), whilecreateKeyboardShortcuttreatsundefinedas don't-care. Every definition specifies all four modifiers to preserve the original behavior. Theshift?optional modifier maps to omittingshift(undefined = don't care).The original code checked generic hotkeys first, then platform-specific ones (both could match on Apple).
createKeyboardShortcutselects apple OR default based on platform, so generic definitions are merged into the apple arrays where both should match.Removed
is-hotkeyand@types/is-hotkeyfrompackage.json.What to review
deleteBackward: genericBackspace(shift optional) + applectrl+Backspace/ctrl+hmoveWordBackward/moveWordForward: genericctrl+arrow+ applealt+arrowredo: windowsctrl+y/ctrl+shift+z, applecmd+shift+zcompose: plain key matching with explicit modifier rejection