Repository navigation
qsp_sim: --verbose-evolve flag (default off) - #29
Merged
Merged
Conversation
…chatter evolve_to_diagnosis was always passing verbose=true into the model-init hook, so every qsp_sim invocation stderr-dumped: - per-species "[healthy] X = N cells" lines (16+ species) - post-evolve "evolve_to_diagnosis: t_diag=... diameter=..." summary - per-365-day "[evolve] t=... d; diameter=..." stepping lines On a 5k SBI sweep this is ~100 lines × 5000 sims of noise that's also captured into the per-sim failure stderr dump by qsp-hpc-tools' batch runner, ballooning crash logs. Flip verbose default to false; gate behind --verbose-evolve. REJECTED cerr stays unconditional — that's a hard error worth surfacing. For parity traces / hand-debug, pass --verbose-evolve explicitly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
evolve_to_diagnosis was always passing
verbose=trueinto the model-init hook, so everyqsp_siminvocation stderr-dumped:[healthy] X = N cellslines (16+ species)evolve_to_diagnosis: t_diag=... diameter=...summary[evolve] t=... d; diameter=...stepping linesOn a 5k SBI sweep this is ~100 lines × 5000 sims of noise that's also captured into the per-sim failure stderr dump by qsp-hpc-tools' batch runner, ballooning crash logs (failure messages observed at >100 lines each).
This PR flips the verbose default to false and adds a
--verbose-evolveCLI flag for parity-trace / hand-debug. TheREJECTEDcerr stays unconditional — that's a hard error worth surfacing.Smoke-tested locally on pdac-build: zero
[healthy]/[evolve]chatter on a baseline-scenario trace;--verbose-evolverestores the old output.