Skip to content

remove the path-to-regexp override - #2358

Merged
kenjenkins merged 1 commit into
mainfrom
kenjenkins/fix-dev-mode
Sep 8, 2026
Merged

remove the path-to-regexp override#2358
kenjenkins merged 1 commit into
mainfrom
kenjenkins/fix-dev-mode

Conversation

@kenjenkins

Copy link
Copy Markdown
Contributor

Summary

The docs site dev mode (npm run start) was failing with the message

[ERROR] TypeError: pathRegexp.match is not a function

(at least on my machine).

I think the overridden path-to-regexp version is no longer compatible with the current express module version. Let's see if we can remove the path-to-regexp override.

Related

n/a

AI disclosure

Claude Opus 4.5 suggested removing the path-to-regexp override.

Checklist

  • reference any related issues
  • disclosed AI usage (or wrote "none") per AI_POLICY.md

@netlify

netlify Bot commented Sep 8, 2026

Copy link
Copy Markdown

Deploy Preview for pomerium-docs ready!

Name Link
🔨 Latest commit 776975a
🔍 Latest deploy log https://app.netlify.com/projects/pomerium-docs/deploys/6aa08869b4a0d00008832b28
😎 Deploy Preview https://deploy-preview-2358--pomerium-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@kenjenkins
kenjenkins marked this pull request as ready for review September 8, 2026 22:17
@kenjenkins
kenjenkins requested a review from a team as a code owner September 8, 2026 22:17
@kenjenkins
kenjenkins requested review from nickytonline and removed request for a team September 8, 2026 22:17
@greptile-apps

greptile-apps Bot commented Sep 8, 2026

Copy link
Copy Markdown

Greptile Summary

This PR removes the global path-to-regexp@0.1.13 override and updates the lockfile so each dependent package receives a compatible major version.

  • serve-handler resolves path-to-regexp@3.3.0.
  • react-router receives a nested path-to-regexp@1.9.0.
  • Express's router receives a nested path-to-regexp@8.4.2.
  • The resulting dependency tree is consistent with the repository's npm 11 toolchain.

Confidence Score: 5/5

The PR appears safe to merge because the dependency tree now satisfies each consumer's declared path-to-regexp range.

No actionable failure remains; the removed override was forcing an incompatible old API, while the updated lockfile consistently isolates the three required major versions under the supported npm 11 toolchain.

Important Files Changed

Filename Overview
package.json Removes the global path-to-regexp override so transitive consumers can resolve their declared compatible versions.
package-lock.json Records internally consistent path-to-regexp versions for serve-handler, react-router, and router, including the required isarray dependency.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  D[Docusaurus] --> SH[serve-handler]
  SH --> P3[path-to-regexp 3.3.0]
  D --> RR[react-router 5.3.4]
  RR --> P1[path-to-regexp 1.9.0]
  E[Express 5] --> R[router 2.2.0]
  R --> P8[path-to-regexp 8.4.2]
Loading

Reviews (1): Last reviewed commit: "remove the path-to-regexp override" | Re-trigger Greptile

@kenjenkins
kenjenkins merged commit 0acc473 into main Sep 8, 2026
12 checks passed
@kenjenkins
kenjenkins deleted the kenjenkins/fix-dev-mode branch September 8, 2026 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants