remove the path-to-regexp override - #2358
Merged
Merged
Conversation
✅ Deploy Preview for pomerium-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
kenjenkins
marked this pull request as ready for review
September 8, 2026 22:17
kenjenkins
requested review from
nickytonline
and removed request for
a team
September 8, 2026 22:17
Greptile SummaryThis PR removes the global
Confidence Score: 5/5The PR appears safe to merge because the dependency tree now satisfies each consumer's declared No actionable failure remains; the removed override was forcing an incompatible old API, while the updated lockfile consistently isolates the three required major versions under the supported npm 11 toolchain.
|
| Filename | Overview |
|---|---|
| package.json | Removes the global path-to-regexp override so transitive consumers can resolve their declared compatible versions. |
| package-lock.json | Records internally consistent path-to-regexp versions for serve-handler, react-router, and router, including the required isarray dependency. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
D[Docusaurus] --> SH[serve-handler]
SH --> P3[path-to-regexp 3.3.0]
D --> RR[react-router 5.3.4]
RR --> P1[path-to-regexp 1.9.0]
E[Express 5] --> R[router 2.2.0]
R --> P8[path-to-regexp 8.4.2]
Reviews (1): Last reviewed commit: "remove the path-to-regexp override" | Re-trigger Greptile
nickytonline
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The docs site dev mode (
npm run start) was failing with the message(at least on my machine).
I think the overridden
path-to-regexpversion is no longer compatible with the currentexpressmodule version. Let's see if we can remove thepath-to-regexpoverride.Related
n/a
AI disclosure
Claude Opus 4.5 suggested removing the
path-to-regexpoverride.Checklist