POK-86: Add ruamel.yaml to dev extra for aikit gateway tests#31
Merged
Conversation
tests/test_aikit_gateway_tools.py imports ruamel.yaml but it was only declared under the pluck extra, so pip install -e .[dev] failed at collection. Include it in dev alongside pytest. Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: multica-agent <github@multica.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ruamel.yamlto thedevoptional dependency group inpyproject.tomltests/test_aikit_gateway_tools.pywhen installing withpip install -e ".[dev,aikit]"(or.[dev]alone) without thepluckextraRoot cause
The aikit gateway-tools test imports
ruamel.yamlto parse rendered YAML configs, but that package was only declared under thepluckextra. CI was unaffected because it installs.[dev,all], which pulls inpluck.Test plan
pip install -e ".[dev,aikit]"thenpytest tests/test_aikit_gateway_tools.py --collect-onlysucceeds (28 tests collected)pip install -e ".[dev,all]"then fullpytestsuite passesCloses POK-86