Integrate CasePaths trait#220
Open
vladyslavsosiuk wants to merge 2 commits into
Open
Conversation
e6011ff to
2ba62d8
Compare
2ba62d8 to
8a755c9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on slack discussion:
https://pointfreecommunity.slack.com/archives/C04L2D8PN4D/p1781144641623609
With the recent soundness hole fix in Swift it is no longer possible to derive a Shared "view" into an enum's case:
This PR implements an approach similar to https://github.com/pointfreeco/swift-navigation/blob/7d1f9d77cf4eacde94c8ffa19fe6ba6a9c37bdb7/Sources/SwiftNavigation/UIBinding.swift#L412-L428 that allows to derive a "view" into enum case and it even let's one avoid wrapping in a Shared.init(_):