Support for ancestor records in mock cloud database #389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbrandonw
commented
Jan 28, 2026
Comment on lines
-30
to
+51
| package var records: [CKRecord.ID: CKRecord] = [:] | ||
| package var entries: [CKRecord.ID: RecordEntry] = [:] | ||
| } | ||
|
|
||
| package struct RecordEntry { | ||
| package var record: CKRecord | ||
| package var history: [Int: CKRecord] |
Member
Author
There was a problem hiding this comment.
Beefed this up so that we don't hold just a record at a record ID, but also a history that maps record change tag to past record.
stephencelis
approved these changes
Jan 28, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we wanna get into 3-way merging stuff we should have a representation of this in our mock cloud database.