Skip to content

ci(commitlint): ignore dependabot bump commits#51

Merged
kj-podonos merged 1 commit into
mainfrom
ci/commitlint-ignore-dependabot
Jun 18, 2026
Merged

ci(commitlint): ignore dependabot bump commits#51
kj-podonos merged 1 commit into
mainfrom
ci/commitlint-ignore-dependabot

Conversation

@kj-podonos

Copy link
Copy Markdown
Contributor

What

Migrate .commitlintrc.jsoncommitlint.config.cjs and add a function-based
ignores rule that skips Dependabot's default Bump <dep> from <x> to <y>
commit subject.

Why

The lint (commitlint) check fails on dependabot PRs whose commit subject lacks
a Conventional Commits type: prefix — type-empty + subject-empty.

.github/dependabot.yml already sets commit-message.prefix: chore, and it works
for github-actions updates (PRs #45–49 are chore(deps): bump …). But it is
not applied to indirect/transitive pip deps, so PR #50
(Bump cryptography from 48.0.0 to 48.0.1) failed commitlint while all 18 test
matrix jobs passed. This is a recurring gap for future transitive bumps.

A function-based ignores predicate can't live in JSON, hence the .cjs migration.
extends (@commitlint/config-conventional) and the body-max-line-length rule
are preserved unchanged.

Verification

  • Config loads and the predicate ignores Bump … from … to … while still linting
    normal/chore(deps): commits (verified locally via node).
  • CI commitlint job is the real gate on this PR.

Unblocks re-driving #50 (cryptography 48.0.1).

🤖 Generated with Claude Code

@kj-podonos kj-podonos self-assigned this Jun 17, 2026
@kj-podonos kj-podonos force-pushed the ci/commitlint-ignore-dependabot branch from fdc565f to c03e210 Compare June 17, 2026 11:09
@kj-podonos kj-podonos force-pushed the ci/commitlint-ignore-dependabot branch from c03e210 to aee71c7 Compare June 18, 2026 01:42
Migrate .commitlintrc.json to commitlint.config.cjs so we can use a
function-based `ignores` rule (not expressible in JSON). Ignore Dependabot's
default `Bump <dep> from <x> to <y>` subject, which has no Conventional Commits
type prefix and is produced for indirect (transitive) dependency updates even
though .github/dependabot.yml sets a `chore` prefix. That mismatch failed the
commitlint check on PR #50 (cryptography 48.0.1).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@kj-podonos kj-podonos force-pushed the ci/commitlint-ignore-dependabot branch from aee71c7 to 45bf8bf Compare June 18, 2026 03:38
@kj-podonos kj-podonos merged commit f904531 into main Jun 18, 2026
18 checks passed
@kj-podonos kj-podonos deleted the ci/commitlint-ignore-dependabot branch June 18, 2026 03:44
kj-podonos added a commit that referenced this pull request Jun 18, 2026
## Summary
Bumps the transitive dependency **cryptography** `48.0.0 → 49.0.0` in
`uv.lock`.

Supersedes the stale dependabot PR #50 (targeted 48.0.1; its branch was
deleted
after the commitlint fix #51 landed). 49.0.0 is the current latest.

## Compatibility
- **Transitive, dev-only, linux-only:** pulled in via `twine → keyring →
secretstorage`; `secretstorage` carries `sys_platform == 'linux'`.
**Zero direct usage** in `src/` or `tests/`.
- `secretstorage` depends on `cryptography` with no upper bound → 49.0.0
satisfies it (uv resolved 72 pkgs, only cryptography changed).
- Lock has `cp39-abi3` wheels → cryptography 49.0.0 supports **Python ≥
3.9**; repo requires `>= 3.10`. manylinux_2_28/2_34 + musllinux wheels
present.
- Lock-only change; no source touched.

## Test plan
- [ ] CI matrix green (Python 3.10–3.14 × ubuntu/macos/windows)
- [ ] `fresh-venv-smoke` green (real install)
- [ ] `lint` green (conventional commit)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant