test/system: two more flake fixes#28836
Open
Luap99 wants to merge 2 commits into
Open
Conversation
In the new CI with run with many parallel jobs (8) and that is messing up timings a fair but, any command might take unexpected long to scheduling delays and lock holding by other tests. Any test doing a podman ps -a while need to take all container locks for example and that then can delay the stop command an unknown amount of time, bump the timeout to 8 and use a higher stop timeout so we are still testing that we exit before the wait timeout is reached. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
The test flakes on the socat pid kill when the pid already exited. Because the timeout is just 10s we can just bump it to something loinger to ensure the process is still alive when we kill it. Also move it up a bit so the kill happens earlier. I observed multiple time failing with test times of 11s+. This should be enough to make it work properly. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Merged
Contributor
Author
|
Ok so the path filter for just system tests worked, that is good. FWIW here is the example what I meant today in the meeting with github does not expand the matrix when the job is skipped for some reason 
Looks weird but I guess it is harmless |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
observed in the new CI
Does this PR introduce a user-facing change?