Some improvements for libpod#28812
Open
bit-hope wants to merge 1 commit into
Open
Conversation
baude
reviewed
May 29, 2026
Contributor
|
THe CI is happy due to the lack of a new test with this PR. Once added, this should be GTG. Changes otherwise LGTM |
bit-hope
force-pushed
the
improvements-for-libpod
branch
2 times, most recently
from
c837870 to
d87d00d
Compare
Honny1
requested changes
Jun 1, 2026
bit-hope
force-pushed
the
improvements-for-libpod
branch
from
b8de8b0 to
a80d6b0
Compare
Honny1
requested changes
Jun 1, 2026
Honny1
reviewed
Jun 1, 2026
Contributor
Honny1
left a comment
Honny1
left a comment
There was a problem hiding this comment.
Also, please squish commits. Thanks
bit-hope
force-pushed
the
improvements-for-libpod
branch
from
a80d6b0 to
1fc5b6e
Compare
Honny1
reviewed
Jun 1, 2026
Contributor
Honny1
left a comment
Honny1
left a comment
There was a problem hiding this comment.
LGTM, thanks!
Please hold off on rebasing on main until the new CI is working upstream (Cirrus CI is dead). We have a PR ready to fix this and hope it merges soon. I will ping you when you're good to rebase.
Honny1
approved these changes
Jun 1, 2026
Contributor
Author
Ok. |
Contributor
|
You can do a rebase. @bit-hope |
Signed-off-by: zhongchunhe.zch <zhongchunhe.zch@qq.com>
bit-hope
force-pushed
the
improvements-for-libpod
branch
from
1fc5b6e to
6b9d6da
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Ensure you have completed the following checklist for your pull request to be reviewed:
commits. (
git commit -s). (If needed, usegit commit -s --amend). The author email must matchthe sign-off email address. See CONTRIBUTING.md
for more information.
Fixes: #00000in commit message (if applicable)make validatepr(format/lint checks)Noneif no user-facing changes)Does this PR introduce a user-facing change?