Revert "storage: improve error message on image mount from r/o store"#965
Merged
Conversation
This reverts commit 006839b. This is causes test failures in both podman and buildah tests[1]. The return error was changed so buildah can no longer match it. For the next podman release we need to vendor some pasta changes so we like a working container-libs. This can be reapplied once podman/buildah are known to work with this. podman-container-tools#945 (comment) Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Member
Author
|
merging to unblock the podman side |
mtrmac
reviewed
Jul 7, 2026
mtrmac
left a comment
mtrmac
left a comment
Contributor
There was a problem hiding this comment.
LGTM, for the record. Thanks!
Contributor
|
LGTM indeed. Did some analysis at #945 (comment) |
Contributor
|
We successfully released podman 6.0.1. I think we can revert this and create PRs for Buildah with vendoring of the change and fix. How do we proceed with this? |
Contributor
|
@Honny1 I think a draft PR here + test PRs vendoring into Buildah + Podman would be best; after the 3 PRs pass review and tests, quickly merge all three. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 006839b.
This is causes test failures in both podman and buildah tests[1]. The return error was changed so buildah can no longer match it.
For the next podman release we need to vendor some pasta changes so we like a working container-libs. This can be reapplied once podman/buildah are known to work with this.
#945 (comment)