Refactor: Move cliutils to commands._cliutils - #216
Merged
Conversation
Moved all implementations from `src/dictknife/cliutils` to `src/dictknife/commands/_cliutils.py`. Updated all import paths accordingly.
Updated the import path for `traceback_shortly` in `src/dictknife/langhelpers.py` to point to the new location in `src/dictknife/commands/_cliutils.py`. This resolves the `ModuleNotFoundError` that occurred during CI testing after the initial refactoring.
Reverted changes in `src/dictknife/langhelpers.py` to investigate the `NameError: name 'make_dict' is not defined` error occurring in CI. This is an attempt to isolate the cause of the error that appeared after refactoring cliutils.
Added the missing import `from dictknife.langhelpers import make_dict` in `src/dictknife/commands/jsonknife.py`. This resolves the `NameError` that occurred during CI testing. Additionally, ensured the import path for `traceback_shortly` in `src/dictknife/langhelpers.py` is correctly pointing to `commands._cliutils`.
Added the missing import `from dictknife.langhelpers import make_dict` in `src/dictknife/commands/dictknife.py`. This resolves the `NameError` that occurred during CI testing after the refactoring of cliutils and subsequent fixes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved all implementations from
src/dictknife/cliutilstosrc/dictknife/commands/_cliutils.py. Updated all import paths accordingly.