Adds PR review skill and checklist for pull request evaluations#7227
Open
waldekmastykarz wants to merge 9 commits into
Open
Adds PR review skill and checklist for pull request evaluations#7227waldekmastykarz wants to merge 9 commits into
waldekmastykarz wants to merge 9 commits into
Conversation
Co-authored-by: Copilot <copilot@github.com>
Contributor
|
Isn't this simular to #7193? |
Member
Author
|
Yes it is. @milanholemans and I crossed streams. Like we agreed, we closed his PR in favor of this one. |
milanholemans
requested changes
Jun 7, 2026
milanholemans
left a comment
milanholemans
left a comment
Contributor
There was a problem hiding this comment.
Looks promising, would like to see this in action. Made a few remarks while reviewing the skill.
Co-authored-by: Milan Holemans <11723921+milanholemans@users.noreply.github.com>
Co-authored-by: Milan Holemans <11723921+milanholemans@users.noreply.github.com>
- Remove obsolete PII/telemetry tracking rule (handled centrally by Zod) - Replace 'All tests must pass' with 'npm test must pass without errors' - Add Documentation Quality section (D) to SKILL.md - Add Reference Commands section pointing to example implementations Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Replace optionSet rule with custom Zod validation (option sets obsolete) - Add test checks: command name/description not null, schema validation - Add sinon.restore() in after() rule for tests Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Remove MkDocs warning check (not applicable to Docusaurus) - Add command page sections check to documentation - Remove logger.logToStderr from SKILL.md (enforced by ESLint) - Remove telemetry mention from SKILL.md (handled centrally by Zod) - Add verbose logging requirement to SKILL.md - Clarify defaultProperties is for list commands only - Specify formatting utilities for escaping user input Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.