Add initialisers with NSAttributedString#85
Open
JeanCharlesNeboit wants to merge 1 commit intopmusolino:masterfrom
JeanCharlesNeboit:master
Open
Add initialisers with NSAttributedString#85JeanCharlesNeboit wants to merge 1 commit intopmusolino:masterfrom JeanCharlesNeboit:master
JeanCharlesNeboit wants to merge 1 commit intopmusolino:masterfrom
JeanCharlesNeboit:master
Conversation
Owner
|
Hi there. Thanks for opening this PR. What is the reason to have custom initializer when you have the possibility to works on labels? |
Author
|
Hi @pmusolino. You are right but I think it's more elegant to use specialised initialiser instead of create an instance of alert with String initialiser and afterwards set the attributedText property. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add initialisers to PMAlertController and PMAlertAction classes to allow customise the alert even more.