Repository navigation
Bug/nullable build warnings - #122
Merged
Merged
Conversation
…ldDefault Non-nullable reference properties without a fixture, mock, or default value fell back to `default(T)` in generated code, which the compiler flags as a null-to-non-nullable conversion. The generator suppressed the resulting CS8604 with a pragma but never suppressed the underlying CS8625, so any consumer with WarningsAsErrors=nullable (as this repo itself uses) would hit a hard build error instead of a warning. Apply the null-forgiving operator directly to the default(T) fallback, matching the pattern already used for the AutoFixture branch, instead of pragma-suppressing the whole method body. Enable Nullable on the "without assembly info" integration test project to cover the no-fixture, no-mock, nullable-enabled path, and add a BuildDefault() runtime test that was previously only compiled, never executed. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#121