Skip to content

use getProperty to get the property values - #84

Merged
erral merged 4 commits into
masterfrom
erral-use-getproperty
Aug 7, 2026
Merged

use getProperty to get the property values#84
erral merged 4 commits into
masterfrom
erral-use-getproperty

Conversation

@erral

@erral erral commented Jul 16, 2026

Copy link
Copy Markdown
Member
  • I signed and returned the Plone Contributor Agreement, and received and accepted an invitation to join a team in the Plone GitHub organization.
  • I verified there aren't any other open pull requests for the same change.
  • I followed the guidelines in Contributing to Plone.
  • I successfully ran code quality checks on my changes locally.
  • I successfully ran tests on my changes locally.
  • If needed, I added new tests for my changes.
  • If needed, I added documentation for my changes.
  • I included a change log entry in my commits.

If we move to use getProperty to get the value of the properties that can be modified through the ZMI, we can use products like collective.regenv to override the values in the ZMI from a YAML file and the environment variables.

@erral
erral requested a review from mamico July 16, 2026 12:44
@mister-roboto

Copy link
Copy Markdown

@erral thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@erral

erral commented Jul 16, 2026

Copy link
Copy Markdown
Member Author

@jenkins-plone-org please run jobs

Comment thread src/plone/session/plugins/session.py Outdated
erral and others added 2 commits July 28, 2026 18:05
@erral

erral commented Jul 28, 2026

Copy link
Copy Markdown
Member Author

@jenkins-plone-org please run jobs

@erral

erral commented Aug 6, 2026

Copy link
Copy Markdown
Member Author

@jenkins-plone-org please run jobs

@erral
erral merged commit 3118e78 into master Aug 7, 2026
7 checks passed
@erral
erral deleted the erral-use-getproperty branch August 7, 2026 11:45
@erral
erral restored the erral-use-getproperty branch August 7, 2026 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants