Conversation
mauritsvanrees
left a comment
There was a problem hiding this comment.
LGTM. I tried with a simple text like this and it remained:
# START-MARKER-MANUAL-CONFIG
[random]
stuff = "test"
# END-MARKER-MANUAL-CONFIG
It breaks when the file does not exist yet though. See inline suggestion.
davisagli
left a comment
There was a problem hiding this comment.
Wouldn't it be possible to make it keep the project table without special markers?
0ea9879 to
e4f814b
Compare
|
@davisagli I guess so, yes, we can read the file with OTOH, all other files managed by By keeping these comments we ensure that anyone wanting to modify the trove classifiers of a random python distribution might first think "oops I can not do it (reading the comment at the top)" but then by seen the markers will think "oh, but here I can edit freely, cool". From a developers experience I would say that keeping the markers makes more sense. Either that, or we modify the comment at the top stating that the project table is copied verbatim whenver |
|
@gforcada I don't feel strongly. Try something (this way is fine) and we can adjust if needed. |
This is split from #355 as that is getting broader and broader 😅
Or rather, smaller PRs are simpler to review and merge ✨
Here, we ensure that if there is some special comments on
pyproject.tomlwhatever is between them it is kept verbatim wheneverconfig-packageis run.This is a stepping stone for #355