Skip to content

fix(gha): run meta jobs on maintenance branches#354

Merged
gforcada merged 3 commits into2.xfrom
337-fix-gha-on-maintenance-branches
Mar 12, 2026
Merged

fix(gha): run meta jobs on maintenance branches#354
gforcada merged 3 commits into2.xfrom
337-fix-gha-on-maintenance-branches

Conversation

@gforcada
Copy link
Member

Closes #337

As it was restricted to main and master any maintenance branch, say 3.x would never run GHA from this file, i.e. qa, dependencies, coverage, etc.

As it was restricted to `main` and `master` any maintenance branch, say `3.x` would never run GHA from this file, i.e. qa, dependencies, coverage, etc.
Copy link
Member

@mauritsvanrees mauritsvanrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing this in plone/plone.namedfile#203

I was mostly checking if any jobs would run double: once for being a push and once for being part of a pull request. But that does not happen. That is good.

But: if there is a PR with a branch from outside the plone org, I'm not sure if any tests are run. Well, it is still a push to a branch, so probably fine. But we may want to test.

Oh, I would definitely want to keep the workflow_dispatch option.

@mauritsvanrees
Copy link
Member

I was mostly checking if any jobs would run double: once for being a push and once for being part of a pull request. But that does not happen. That is good.

But: if there is a PR with a branch from outside the plone org, I'm not sure if any tests are run. Well, it is still a push to a branch, so probably fine. But we may want to test.

I created a branch from a fork:
plone/plone.namedfile#204
The 'on push' tests are executed, so that is fine.

Then I included pull_request there as well, and as expected this doubled the amount of jobs. So leaving out pull_request is fine.

Theoretically it could be nice to use on push for main, master and *.x (if that is supported) and on pull_request without restrictions. Then a push to my-WIP-branch would not run any jobs, until I am ready and create an actual PR from that branch. But that is a bit tricky and without much value.

@mauritsvanrees
Copy link
Member

I have pushed a commit to restore the workflow_dispatch trigger in meta.yml

I have added this workflow_dispatch trigger for generated test-matrix workflows as well. I am surprised it was not there yet.

@gforcada gforcada merged commit 733423f into 2.x Mar 12, 2026
1 check passed
@gforcada gforcada deleted the 337-fix-gha-on-maintenance-branches branch March 12, 2026 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Branch names in GitHub Actions workflows

2 participants