fix(gha): run meta jobs on maintenance branches#354
Conversation
As it was restricted to `main` and `master` any maintenance branch, say `3.x` would never run GHA from this file, i.e. qa, dependencies, coverage, etc.
mauritsvanrees
left a comment
There was a problem hiding this comment.
Testing this in plone/plone.namedfile#203
I was mostly checking if any jobs would run double: once for being a push and once for being part of a pull request. But that does not happen. That is good.
But: if there is a PR with a branch from outside the plone org, I'm not sure if any tests are run. Well, it is still a push to a branch, so probably fine. But we may want to test.
Oh, I would definitely want to keep the workflow_dispatch option.
I created a branch from a fork: Then I included Theoretically it could be nice to use |
Restore this for the QA workflow as well.
|
I have pushed a commit to restore the I have added this workflow_dispatch trigger for generated test-matrix workflows as well. I am surprised it was not there yet. |
Closes #337
As it was restricted to
mainandmasterany maintenance branch, say3.xwould never run GHA from this file, i.e. qa, dependencies, coverage, etc.