Open
Conversation
Member
|
This is not what I want for my packages, but it is what I usually have (fullrelease locally) so I'm very happy 😄 |
mauritsvanrees
requested changes
Nov 21, 2023
Member
mauritsvanrees
left a comment
mauritsvanrees
left a comment
There was a problem hiding this comment.
See suggested change.
Other than that, it should be fine.
But I won't use it myself for core Plone packages: I release those within a checkout of the coredev buildout, and make a release by doing ../../bin/fullrelease.
config/default/tox.ini.j2
Outdated
| description = create a new release | ||
| skip_install = true | ||
| deps = | ||
| zest.release[recommended] |
Member
There was a problem hiding this comment.
Typo in zest.releaser. And we should add two that are not in the recommended list:
Suggested change
| zest.release[recommended] | |
| zest.releaser[recommended] | |
| zest.pocompile | |
| zestreleaser.towncrier |
gforcada
force-pushed
the
release-distribution
branch
from
8571ec1 to
dcf3438
Compare
gforcada
force-pushed
the
release-distribution
branch
from
dcf3438 to
87184ff
Compare
Install and run `zest.releaser`'s `fullrelease` command to generate, and upload a new release of the distribution.
gforcada
force-pushed
the
release-distribution
branch
from
87184ff to
a372ce8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially is #100 but it does simply install and call
fullreleasefromzest.releaser.This way, it all still happens locally... from a security point of view, maybe that's best? Otherwise any random developer can do:
git clone https://github.com/plone/plone.batching cd plone.batching tox -e release💥
Do we want that? 🤔
If we only call
fullreleaseontox -e releaseif you don't have upload permissions on PyPI the release is not uploaded. 🩹This together with the #187 it will create both releases on PyPI but also on GitHub 🎉
And if we expand mr.roboto(?) to monitor releases in GitHub, we can map new Plone distributions' releases with in which Plone version they are used (i.e.
plone.batchingnew release should be added to both Plone6.0and6.1).At the end that would be to (partially) merge
plone.releasertomr.roboto.@mauritsvanrees not sure how comfortable you would be with this change, and if that makes sense at all 🤔
The grand idea behind all this stepping stones is to distribute the load to create new releases while at the same time keep all those new versions finding their way to the right Plone version.
I'm thinking about refactoring code, for example, one needs to wait for the other distribution to be released with the code that has been moved there, to be able to depend on it.
If a new release on the first distribution finds its way on the
plone-6xx-dev.txtrequirements file, then we can depend on these files being updated automatically upon a new release.@davisagli @jensens @ericof (and others of course!) opinions? Probably we should move this to community.plone.org?