Relax agent-client-protocol pin to >=0.11.0,<1 - #501
Merged
Merged
Conversation
Allows coexistence with jupyter-ai in the same environment (fixes plmbr#500); jupyter-ai-acp-client>=0.3.0 requires agent-client-protocol>=0.11.0,<0.12.0, which is unresolvable against the old ==0.10.1 exact pin. Verified 0.11-0.12 compatible with acp_agent.py's Client/schema usage. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
mbektas
approved these changes
Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
agent-client-protocoldependency from an exact pin (==0.10.1) to a range (>=0.11.0,<1).notebook-intelligenceandjupyter-aito coexist in the same environment.jupyter-ai-acp-client>=0.3.0requiresagent-client-protocol>=0.11.0,<0.12.0, which had zero overlap with our old exact pin.acp_agent.py's actualClient/schema usage: the new HTTP/WebSocket transports and elicitation subsystem are unused here, the removedSetSessionModelRequest/SetSessionModelResponseare unused here, and theAgentinterface parameter reordering doesn't matter since dispatch always calls handlers via**kwargs.Test plan
agent-client-protocol0.10.1 vs 0.11.0/0.12.1 wheels (acp/__init__.py,core.py,interfaces.py,schema.py,exceptions.py) againstacp_agent.py's usage surfacepytest tests/ -qjupyter-ai>=3.2.0and confirm dependency resolution succeeds🤖 Generated with Claude Code