Repository navigation
Conversation
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
This reverts commit 6ca475d.
tjduigna
left a comment
There was a problem hiding this comment.
Thanks for the updates. Please address the existing-release update regression noted inline before merging. All required CI checks pass.
| _fetch_scalar( | ||
| connection, | ||
| "SELECT count(*) FROM entry_chains WHERE " | ||
| "chain_unresolved_fraction IS DISTINCT FROM " |
There was a problem hiding this comment.
[P2] Backfill chain completeness before validating updates to existing releases
Please backfill chain_unresolved_fraction for retained legacy rows before this check. The documented update_entries flow keeps old_rows.*: releases produced by the base revision lack this column, so removal-only updates fail here. With incoming rows, UNION ALL BY NAME fills the retained rows with null, which also fails this comparison. The weekly-update fixture now supplies the field, so passing CI does not cover this case. Derive the legacy value from the existing count/length columns, preserve validation of supplied values, and add a base-format removal-only regression test.
Summary