Repository navigation
docs(boost): prefer an interface for mail - #53
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Boost skill answered the same question in two opposite ways, and an AI agent following it could land on either.
The question is: an action has to send a mail, the mail class lives in the infrastructure layer, and the application layer must not import infrastructure. What do you do?
One section of the skill said to add an interface in the application layer, implement it in infrastructure, and never widen
validation.application_infrastructure_allowedto skip it. Twenty lines below, another section offered exactly that list as the way out for "sending mail or a notification straight from an action".I ran the same task twice on a real app. The first run produced an interface with a mail implementation behind it. The second run imported the mail class from the action and added
Mailto the allow list. Both runs were following the skill.This change makes the interface the default and says so with a mail example (
RegistrationNotifierin the application layer, the class that sends the mail in infrastructure). The allow list stays documented, but as a decision the project has already written in its config. When the list is empty, the skill now tells the agent not to add to it just to make a violation go away.Only the skill text and the changelog change. No code, no generated file, no config default is touched, so this fits a patch release.