Repository navigation
feat(rules): report classes outside the layers - #49
Merged
Merged
Conversation
danielebarbaro
force-pushed
the
feat/no-classes-outside-layers
branch
from
November 16, 2026 13:09
768e2cf to
d0f8999
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The phparkitect rules only look inside the three layer folders. Anything left in
app/Http,app/Models,app/Actionsorapp/Filamentis never checked, sophparkitect checkpasses even on an app that is only half migrated.This adds an opt in rule,
validation.rules.no_classes_outside_layers. When it's on, every class underApphas to live in one of the layers. A few namespaces can stay outside throughvalidation.outside_layers_allowed, which defaults to['Providers']because that's where Laravel keeps service providers.A few details:
app/once instead of each layer, so nothing is checked twice. With it off, the output is unchanged.clean-arch:make-arch-rulesrefuses to write the file if the layers don't share a top level folder, or if the allow list has an invalid entry.phparkitect checkon a small fixture.Nothing changes unless you turn the rule on. Minor release.