Adds Pytest teardown to close figures#437
Merged
Merged
Conversation
for closing all figures, removing the extraneous plt.close calls
for more information, see https://pre-commit.ci
…into pytest-teardown
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the change in this PR at a high-level
This PR adds pytest fixtures so we can use them as a teardown to run after tests that create plots. This way we can close tests correctly (no matter how the test ends) and automatically (so we don't have to remember to add it to each test).
Also figured this out for doctests, where the proper thing to do is to add a
conftest.pyto the same directory tree as the doctests, i.e., thesrc/folder. (See docs).I have added the teardown:
tests/test_display(with autouse)tests/test_models(without autouse, needs to be individually activated)I could've just put it in
test/conftest.pyand automatically applied it to all tests, but the overwhelming majority of our tests don't create matplotlib figures, so that seems like overkill.Checklist
Affirm that you have done the following:
docs/, or (for large changes) adding new files to thedocs/folder.rstfiles indocs/api/or adding a new file as necessary.