Fix budget expense ordering - #272
Open
ryanduguid wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Sort mapped budget expenses case-insensitively by name before publishing the domain list. Expense IDs provide a deterministic tie-breaker when names compare equally.
This keeps budget cards in the same order across reloads even though the persisted expenses originate from an unordered set. Focused mapper tests cover reverse source order and duplicate names.
Type of change
Additional information
Verification
./gradlew test --tests 'com.jongsoft.finance.budget.domain.jpa.mapper.BudgetMapperTest' --tests 'com.jongsoft.finance.budget.domain.jpa.BudgetProviderJpaIT' --rerun-tasks -q— passed (6 tests)./gradlew classes -q— passed./gradlew check -x classes -q— 234 tests completed with one unrelated failure:BankAccountTest.createSavingsAccountWithGoalsexpectsmonthsLeft6 but receives 5. The same failure was reproduced on untouchedmaster.Checklist