Skip to content

Make please_go cover handle the possiblity that every src is outside the package directory #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
toastwaffle merged 2 commits into from
Sep 4, 2026
Merged

Make please_go cover handle the possiblity that every src is outside the package directory #385

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7acaae0
Make `please_go cover` handle the possiblity that every src is outsid…
toastwaffle Sep 4, 2026
09abd66
Version bump
toastwaffle Sep 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions tools/please_go/ChangeLog
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
Version 1.26.1
--------------
* Make `please_go cover` handle the possiblity that every src is outside the package directory (#385)

Version 1.26.0
--------------
* `generate`: rename `third_part_folder` option to `deps_path`, and remove `t` short option (#379)
Expand Down
2 changes: 1 addition & 1 deletion tools/please_go/VERSION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
1.26.0
1.26.1
11 changes: 10 additions & 1 deletion tools/please_go/cover/cover.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ package cover
import (
"bytes"
"encoding/json"
"fmt"
"go/parser"
"go/token"
"log"
Expand All @@ -23,6 +24,14 @@ func WriteCoverage(goTool, coverTool, covercfg, output, pkgConfigFile, pkg strin
return err
}

// It is entirely possible that all of the sources to a build target are outside the package
// directory (which is usually the result of using the outputs of other targets as srcs).
// `go tool cover` still wants to write the `_covervars.cover.go` file to the package directory,
// so first ensure that it exists.
if err := os.MkdirAll(pkg, 0755); err != nil {
return fmt.Errorf("ensure package directory exists: %w", err)
}

b, _ := json.Marshal(coverConfig{
OutConfig: covercfg,
PkgPath: pkg,
Expand All @@ -38,7 +47,7 @@ func WriteCoverage(goTool, coverTool, covercfg, output, pkgConfigFile, pkg strin
// 1.27 needs package-relative paths (https://go.dev/issue/70478)
needRelativePaths := needs127RelativePaths(goTool)
if coverTool != "" || needRelativePaths || need121CoverVars {
buf.WriteString(filepath.Join(filepath.Dir(srcs[0]), "_covervars.cover.go\n"))
buf.WriteString(filepath.Join(pkg, "_covervars.cover.go\n"))
}
for _, src := range srcs {
buf.WriteString(strings.TrimSuffix(src, ".go") + ".cover.go\n")
Expand Down