Add definitions parameter to go_repo - #378
Merged
chrisnovakovic merged 2 commits intoSep 2, 2026
Merged
Conversation
This sets the given value of `definitions` on `go_binary` and `cgo_binary` targets generated within the subrepo. This is useful for replicating the behaviour of third-party binary build pipelines in Please (e.g. by allowing version strings to be set dynamically during linking).
peterebden
reviewed
Sep 2, 2026
toastwaffle
approved these changes
Sep 2, 2026
| label_args, | ||
| large_package_args, | ||
| f"--src_root={pkgRoot}", | ||
| f"--third_part_folder='{third_party_path}'", |
Contributor
There was a problem hiding this comment.
Really, it's third_part_folder?! 😮💨
Contributor
Author
There was a problem hiding this comment.
Really, it's
third_part_folder?! 😮💨
Yeah, spotted this a while ago and have been meaning to fix it (and rename folder to dir)...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This sets the given value of
definitionsongo_binaryandcgo_binarytargets generated within the subrepo. This is useful for replicating the behaviour of third-party binary build pipelines in Please (e.g. by allowing version strings to be set dynamically during linking).