Generate definitions parameter for Go binary targets - #375
Merged
chrisnovakovic merged 2 commits intoSep 2, 2026
Conversation
In `please_go generate`, pass through the given values of `-D`/`--definition` to the `definitions` parameter when generating `go_binary` and `cgo_binary` targets.
toastwaffle
approved these changes
Sep 2, 2026
toastwaffle
left a comment
toastwaffle
left a comment
Contributor
There was a problem hiding this comment.
Wanna add a version bump in this PR?
| } | ||
|
|
||
| var definitions []string | ||
| if kind == "cgo_binary" || kind == "go_binary" { |
Contributor
There was a problem hiding this comment.
would it make sense to future-proof this with strings.HasSuffix(kind, "_binary")?
Contributor
Author
There was a problem hiding this comment.
Think I'd prefer to match explicit strings - there's no guarantee that other targets with a _binary suffix will have a definitions parameter.
peterebden
approved these changes
Sep 2, 2026
chrisnovakovic
changed the title
please_go: generate definitions parameter for Go binary targetsdefinitions parameter for Go binary targets
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
please_go generate, pass through the given values of-D/--definitionto thedefinitionsparameter when generatinggo_binaryandcgo_binarytargets.