Skip to content

Use Docker's chmod flag in copy and made playit no longer run as root. #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kevinf100 wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Use Docker's chmod flag in copy and made playit no longer run as root. #96

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ba429fa
Use Docker's chmod flag in copy and made playit no longer run as root.
kevinf100 Aug 27, 2024
3b21055
Do not set user home.
kevinf100 Aug 27, 2024
354765b
Merge branch 'playit-cloud:master' into Dockerfile-None-root-update
kevinf100 Aug 29, 2024
d2e9396
Merge branch 'playit-cloud:master' into Dockerfile-None-root-update
kevinf100 Sep 4, 2024
80ab05e
No more home for user and added SIGTERM handler.
kevinf100 Sep 13, 2024
6cac654
Merge branch 'playit-cloud:master' into Dockerfile-None-root-update
kevinf100 Sep 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,11 +36,15 @@ RUN cargo build --release --all
########## RUNTIME CONTAINER ##########

FROM alpine:3.18
ARG PLAYIT_GUID=2000
ARG PLAYIT_UUID=2000
RUN apk add --no-cache ca-certificates

COPY --from=build-env /src/playit-agent/target/release/playit-cli /usr/local/bin/playit
RUN mkdir /playit
COPY docker/entrypoint.sh /playit/entrypoint.sh
RUN chmod +x /playit/entrypoint.sh
COPY --chmod=1755 docker/entrypoint.sh /playit/

RUN addgroup -g ${PLAYIT_GUID} playit && adduser -S --no-create-home -u ${PLAYIT_UUID} -G playit playit
USER playit

ENTRYPOINT ["/playit/entrypoint.sh"]
16 changes: 15 additions & 1 deletion docker/entrypoint.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,18 @@ if [ -z "${SECRET_KEY}" ]; then
fi
fi

playit -s --secret "${SECRET_KEY}" --platform_docker start
term_handler() {

echo "Shutting down Playit."
kill -SIGTERM $PlayitPID
wait $PlayitPID
exit
}
trap 'term_handler' SIGTERM


playit -s --secret "${SECRET_KEY}" --platform_docker start &

PlayitPID=$!

wait $PlayitPID