Fix: Support custom asset loading for GSplat (getter-only props)#316
Open
No-LAN-B wants to merge 3 commits intoplaycanvas:mainfrom
Open
Fix: Support custom asset loading for GSplat (getter-only props)#316No-LAN-B wants to merge 3 commits intoplaycanvas:mainfrom
No-LAN-B wants to merge 3 commits intoplaycanvas:mainfrom
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem (Addresses Issue - #315 )
Using with a custom-loaded asset (e.g. from a @playcanvas/splat-transform loader) throws:
The same pattern can affect any component that exposes getter-only props (e.g. id).
Root cause
So the failure comes from the generic “apply all schema props” path trying to assign to getter-only props, not from the custom asset loading path itself.
Solution
Getter-only props stay in the schema (so the public API stays complete and anything that relies on them being present still works), but they are never applied, so the “Cannot set property id” error is fixed.
Changes
Result