Format code and add formatting guidelines - #98
Merged
Merged
Conversation
Add a `fmt` job to the release workflow that runs `cargo fmt --all -- --check` so PRs fail when code isn't formatted, and document in AGENTS.md that agents must run `cargo fmt --all` after code changes. Also format existing code so the check passes. https://claude.ai/code/session_01LSAxBMnoN7xwgZSsajZ9ZR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR applies code formatting changes across the repository and establishes formatting standards for future contributions.
Key Changes
Code formatting: Applied
cargo fmtto normalize code style across multiple files:k8s-agent/src/cluster_discovery.rs: Reformatted multi-line attribute macros and function signaturesk8s-agent/src/config.rs: Reformatted multi-line attribute macroschart-discovery/src/main.rs: Reformatted multi-line attribute macroschart-discovery/src/oci_poll.rs: Reformatted import statements for consistencyCI enforcement: Added a new
fmtjob to.github/workflows/release.ymlthat runscargo fmt --all -- --checkto ensure all future contributions maintain consistent formattingDocumentation: Created
AGENTS.mdwith guidelines for contributors, including instructions to runcargo fmt --allbefore committingNotable Details
The formatting changes are purely stylistic and do not alter any functionality. The new CI job will prevent merging of PRs with unformatted code, ensuring the repository maintains consistent code style going forward.
https://claude.ai/code/session_01LSAxBMnoN7xwgZSsajZ9ZR